Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jira Branch Name Convention Support #45

Merged
merged 4 commits into from
Oct 23, 2019
Merged

Jira Branch Name Convention Support #45

merged 4 commits into from
Oct 23, 2019

Conversation

therynamo
Copy link
Contributor

@therynamo therynamo commented Oct 23, 2019

Summary

This PR adds support for SCM integration with Jira. Jira has workflows that use a specific "branching convention" to associate github (and other SCM) pull requests to Jira tickets. That convention is outlined here.

Currently we're only supporting the branch name convention, if we receive asks for the commit convention we can modify CL to look at those as well. Ultimately we want to cut down on API calls to make sure our users do not exceed github api rate limits.

  • Readme updates

Issues

closes #41

@therynamo therynamo added the ✨ feat New feature or request label Oct 23, 2019
@therynamo therynamo self-assigned this Oct 23, 2019

Ignoring an issue or multiple issues is as easy as placing these issues inside of a Captain's Log _"ignore block"_. It is a simple HTML comment block with two special key words, `icl` and `ecl`. This stands for `ignore captain's log` and `end captain's log` (ignore), respectively.
Ignoring an issue or multiple issues is as easy as placing these issues inside of a Captain's Log _"ignore block"_. It is a simple HTML comment block with two special key words, `icl` and `ecl`. This stands for `ignore captain's log` and `end captain's log` (ignore), respectively.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just check the rich diff, these seem to be whitespace cleanups by the editor.

@therynamo
Copy link
Contributor Author

therynamo commented Oct 23, 2019

Looks like the build passed, but it isn't sending the status update to the PR.

@remoz remoz changed the title Jira Branch Name Convetion Support Jira Branch Name Convention Support Oct 23, 2019
Copy link
Contributor

@remoz remoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. Nice work. 😁

Copy link
Contributor

@BRKalow BRKalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, nicely done 👍

@therynamo therynamo merged commit 68e1fca into master Oct 23, 2019
therynamo added a commit that referenced this pull request Mar 15, 2021
* Jira Branch Name Convetion Support

* Update docs

* Typo & Default

* initialize with array
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feat New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Jira Branch Name Convention
3 participants